netdev - Re: [PATCH net-next v3] bnxt_en: New Broadcom ethernet driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151018221958.1b7b9d0d@xeon-e3>
Date:	Sun, 18 Oct 2015 22:19:58 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Michael Chan <mchan@...adcom.com>
Cc:	<davem@...emloft.net>, <prashant@...adcom.com>,
	<eddie.wai@...adcom.com>, <huangjw@...adcom.com>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3] bnxt_en: New Broadcom ethernet driver.

On Sat, 17 Oct 2015 00:21:44 -0400
Michael Chan <mchan@...adcom.com> wrote:

> +static bool bnxt_vf_pciid(int idx)
> +{
> +	if (idx == BCM57304_VF || idx == BCM57404_VF)
> +		return true;
> +	return false;
> +}
> +

I prefer just returning result of logical operation
rather than adding unnecessary if statement.
And never use (signed) int when unsigned is the real
data type. Also avoid any unnecessary expansion of 16 bit
value.

static bool bnxt_vf_pciid(u16 idx)
{
	return (idx == BCM57304_VF || idx == BCM57404_VF);
}
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html