netdev - Re: [PATCH] net, can, ti_hecc: fix a run time warn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56248EE3.4000103@pengutronix.de>
Date:	Mon, 19 Oct 2015 08:34:11 +0200
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Heiko Schocher <hs@...x.de>, linux-kernel@...r.kernel.org
Cc:	netdev@...r.kernel.org, linux-can@...r.kernel.org,
	Wolfgang Grandegger <wg@...ndegger.com>
Subject: Re: [PATCH] net, can, ti_hecc: fix a run time warn_on.

On 10/19/2015 08:22 AM, Heiko Schocher wrote:
> This patch fixes a warning in clk_enable by calling
> clk_prepare_enable instead.

What about the corresponding clk_disable_unprepare()?

Marc

> 
> Signed-off-by: Heiko Schocher <hs@...x.de>
> ---
> 
>  drivers/net/can/ti_hecc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c
> index cf345cb..c08e8ea 100644
> --- a/drivers/net/can/ti_hecc.c
> +++ b/drivers/net/can/ti_hecc.c
> @@ -951,7 +951,7 @@ static int ti_hecc_probe(struct platform_device *pdev)
>  	netif_napi_add(ndev, &priv->napi, ti_hecc_rx_poll,
>  		HECC_DEF_NAPI_WEIGHT);
>  
> -	clk_enable(priv->clk);
> +	clk_prepare_enable(priv->clk);
>  	err = register_candev(ndev);
>  	if (err) {
>  		dev_err(&pdev->dev, "register_candev() failed\n");
> 


-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)