netdev - [net-next:master 1236/1358] net/netfilter/nfnetlink_log.c:320:14: warning: 'flags' may be used uninitialized in this function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <201510191403.EUZF6BCN%fengguang.wu@intel.com>
Date:	Mon, 19 Oct 2015 14:41:09 +0800
From:	kbuild test robot <fengguang.wu@...el.com>
To:	Pablo Neira <pablo@...filter.org>
Cc:	kbuild-all@...org, netdev@...r.kernel.org
Subject: [net-next:master 1236/1358] net/netfilter/nfnetlink_log.c:320:14:
 warning: 'flags' may be used uninitialized in this function

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   371f1c7e0d854796adc622cc3bacfcc5fc638db1
commit: 8cbc870829ecd8f1062f2a756683c80e2d1eae7f [1236/1358] netfilter: nfnetlink_log: validate dependencies to avoid breaking atomicity
config: m68k-sun3_defconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 8cbc870829ecd8f1062f2a756683c80e2d1eae7f
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   net/netfilter/nfnetlink_log.c: In function 'nfulnl_recv_config':
>> net/netfilter/nfnetlink_log.c:320:14: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
     inst->flags = flags;
                 ^
   net/netfilter/nfnetlink_log.c:828:6: note: 'flags' was declared here
     u16 flags;
         ^

vim +/flags +320 net/netfilter/nfnetlink_log.c

0597f268 Harald Welte    2005-08-09  304  }
0597f268 Harald Welte    2005-08-09  305  
0597f268 Harald Welte    2005-08-09  306  static int
0597f268 Harald Welte    2005-08-09  307  nfulnl_set_qthresh(struct nfulnl_instance *inst, u_int32_t qthresh)
0597f268 Harald Welte    2005-08-09  308  {
0597f268 Harald Welte    2005-08-09  309  	spin_lock_bh(&inst->lock);
0597f268 Harald Welte    2005-08-09  310  	inst->qthreshold = qthresh;
0597f268 Harald Welte    2005-08-09  311  	spin_unlock_bh(&inst->lock);
0597f268 Harald Welte    2005-08-09  312  
0597f268 Harald Welte    2005-08-09  313  	return 0;
0597f268 Harald Welte    2005-08-09  314  }
0597f268 Harald Welte    2005-08-09  315  
0af5f6c1 Harald Welte    2006-03-20  316  static int
0af5f6c1 Harald Welte    2006-03-20  317  nfulnl_set_flags(struct nfulnl_instance *inst, u_int16_t flags)
0af5f6c1 Harald Welte    2006-03-20  318  {
0af5f6c1 Harald Welte    2006-03-20  319  	spin_lock_bh(&inst->lock);
ee433530 Patrick McHardy 2006-05-19 @320  	inst->flags = flags;
0af5f6c1 Harald Welte    2006-03-20  321  	spin_unlock_bh(&inst->lock);
0af5f6c1 Harald Welte    2006-03-20  322  
0af5f6c1 Harald Welte    2006-03-20  323  	return 0;
0af5f6c1 Harald Welte    2006-03-20  324  }
0af5f6c1 Harald Welte    2006-03-20  325  
c6a8f648 Michal Miroslaw 2007-09-28  326  static struct sk_buff *
afff14f6 Gao feng        2013-09-23  327  nfulnl_alloc_skb(struct net *net, u32 peer_portid, unsigned int inst_size,
afff14f6 Gao feng        2013-09-23  328  		 unsigned int pkt_size)

:::::: The code at line 320 was first introduced by commit
:::::: ee433530d96a7b0af24ab616e5b51f1d89f9ae38 [NETFILTER]: nfnetlink_log: fix byteorder confusion

:::::: TO: Patrick McHardy <kaber@...sh.net>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (11002 bytes)