netdev - Re: [PATCH net] net: try harder to not reuse ifindex when moving interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151019110649.726f1fe0@griffin>
Date:	Mon, 19 Oct 2015 11:06:49 +0200
From:	Jiri Benc <jbenc@...hat.com>
To:	Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:	netdev@...r.kernel.org, Thomas Haller <thaller@...hat.com>
Subject: Re: [PATCH net] net: try harder to not reuse ifindex when moving
 interfaces

On Sun, 18 Oct 2015 08:11:58 -0700, Alexei Starovoitov wrote:
> it looks dangerous.
> Does it mean that 'for (4B) { create new dev; free old dev; }
> will keep incrementing that max index and dos it eventually?

This is not changed by this patch in any way. As for the current
behavior (with or without my patch), by creating and deleting an
interface, the max index indeed keeps incrementing. There's no DoS,
however, as the index simply wraps to 1 when reaching maxint. See
dev_new_index(). This is something I count on in this patch.

 Jiri

-- 
Jiri Benc
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html