netdev - Re: [PATCH net-next v3] bnxt_en: New Broadcom ethernet driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Oct 2015 16:13:26 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Michael Chan <mchan@...adcom.com>
Cc:	davem@...emloft.net, prashant@...adcom.com, eddie.wai@...adcom.com,
	huangjw@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3] bnxt_en: New Broadcom ethernet driver.

On Sat, Oct 17, 2015 at 12:21:44AM -0400, Michael Chan wrote:
> Broadcom ethernet driver for the new family of NetXtreme-C/E
> ethernet devices.
> 
> v3:
>   - Fixed 2 more sparse warnings.
>   - Removed some unused structures in .h files.
> 
> v2:
>   - Fixed all kbuild test robot reported warnings.
>   - Fixed many of the checkpatch.pl errors and warnings.
>   - Fixed the Kconfig description.
> 
> Acked-by: Eddie Wai <eddie.wai@...adcom.com>
> Acked-by: Jeffrey Huang <huangjw@...adcom.com>
> Signed-off-by: Prashant Sreedharan <prashant@...adcom.com>
> Signed-off-by: Michael Chan <mchan@...adcom.com>
> ---
>  drivers/net/ethernet/broadcom/Kconfig              |   19 +
>  drivers/net/ethernet/broadcom/Makefile             |    1 +
>  drivers/net/ethernet/broadcom/bnxt/Makefile        |    4 +
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c          | 5821 ++++++++++++++++++++
>  drivers/net/ethernet/broadcom/bnxt/bnxt.h          |  994 ++++
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c  | 1150 ++++
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h  |   18 +
>  drivers/net/ethernet/broadcom/bnxt/bnxt_fw_hdr.h   |  104 +
>  drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h      | 4046 ++++++++++++++
>  drivers/net/ethernet/broadcom/bnxt/bnxt_nvm_defs.h |   59 +
>  drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c    |  787 +++
>  drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.h    |   22 +
>  12 files changed, 13025 insertions(+)
>  create mode 100644 drivers/net/ethernet/broadcom/bnxt/Makefile
>  create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt.c
>  create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt.h
>  create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
>  create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h
>  create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_fw_hdr.h
>  create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h
>  create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_nvm_defs.h
>  create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c
>  create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.h

Well, it's a big one!  But overall I'd say it looks pretty good...

I agree with Stephen's style comments, and there are a couple of
strings that are crazy long -- not just a source readability problem,
but things that would be hard to digest in a log as well.  If you
address those then I'll be happy to ACK it.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html