netdev - Re: [PATCH net-next v3] bnxt_en: New Broadcom ethernet driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151020200047.GD23569@tuxdriver.com>
Date:	Tue, 20 Oct 2015 16:00:47 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Michael Chan <mchan@...adcom.com>
Cc:	davem@...emloft.net, prashant@...adcom.com, eddie.wai@...adcom.com,
	huangjw@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3] bnxt_en: New Broadcom ethernet driver.

On Sat, Oct 17, 2015 at 12:21:44AM -0400, Michael Chan wrote:
> Broadcom ethernet driver for the new family of NetXtreme-C/E
> ethernet devices.
> 
> v3:
>   - Fixed 2 more sparse warnings.
>   - Removed some unused structures in .h files.
> 
> v2:
>   - Fixed all kbuild test robot reported warnings.
>   - Fixed many of the checkpatch.pl errors and warnings.
>   - Fixed the Kconfig description.
> 
> Acked-by: Eddie Wai <eddie.wai@...adcom.com>
> Acked-by: Jeffrey Huang <huangjw@...adcom.com>
> Signed-off-by: Prashant Sreedharan <prashant@...adcom.com>
> Signed-off-by: Michael Chan <mchan@...adcom.com>

...

Looks pretty good so far...

> +	if (req.hwrm_intf_maj != resp->hwrm_intf_maj ||
> +	    req.hwrm_intf_min != resp->hwrm_intf_min ||
> +	    req.hwrm_intf_upd != resp->hwrm_intf_upd) {
> +		netdev_warn(bp->dev, "HWRM interface %d.%d.%d does not match driver interface %d.%d.%d.  Please update driver or firmware with matching interface versions.\n",
> +			    resp->hwrm_intf_maj, resp->hwrm_intf_min,
> +			    resp->hwrm_intf_upd, req.hwrm_intf_maj,
> +			    req.hwrm_intf_min, req.hwrm_intf_upd);
> +	}

Any chance we could break that string and/or make it a bit shorter?
Thats a long one! (130+ characters)

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html