netdev - [PATCH 10/15] net: wireless: ath: simplify return flow for carl9170_regwrite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1445439337-19055-11-git-send-email-punitvara@gmail.com>
Date:	Wed, 21 Oct 2015 20:25:32 +0530
From:	Punit Vara <punitvara@...il.com>
To:	kvalo@....qualcomm.com
Cc:	stas.yakovlev@...il.com, chaoming_li@...lsil.com.cn,
	Larry.Finger@...inger.net, chunkeey@...glemail.com,
	sgruszka@...hat.com, brudley@...adcom.com, arend@...adcom.com,
	linville@...driver.com, jirislaby@...il.com, mickflemm@...il.com,
	mcgrof@...not-panic.com, k.eugene.e@...il.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	brcm80211-dev-list@...adcom.com, wcn36xx@...ts.infradead.org,
	johannes.berg@...el.com, meuleman@...adcom.com,
	Punit Vara <punitvara@...il.com>
Subject: [PATCH 10/15] net: wireless: ath: simplify return flow for carl9170_regwrite_result()

This patch is to the carl9170/phy.c file that fixes warning reported by
coccicheck :

 WARNING: end returns can be simplified

I have removed unneccessary variable declaration and simply return flow
for carl9170_regwrite_result()

Signed-off-by: Punit Vara <punitvara@...il.com>
---
 drivers/net/wireless/ath/carl9170/phy.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/net/wireless/ath/carl9170/phy.c b/drivers/net/wireless/ath/carl9170/phy.c
index dca6df1..f3b5434 100644
--- a/drivers/net/wireless/ath/carl9170/phy.c
+++ b/drivers/net/wireless/ath/carl9170/phy.c
@@ -966,7 +966,6 @@ static const struct carl9170_phy_freq_entry carl9170_phy_freq_params[] = {
 static int carl9170_init_rf_bank4_pwr(struct ar9170 *ar, bool band5ghz,
 				      u32 freq, enum carl9170_bw bw)
 {
-	int err;
 	u32 d0, d1, td0, td1, fd0, fd1;
 	u8 chansel;
 	u8 refsel0 = 1, refsel1 = 0;
@@ -1024,11 +1023,7 @@ static int carl9170_init_rf_bank4_pwr(struct ar9170 *ar, bool band5ghz,
 	carl9170_regwrite(0x1c58e8, fd1);
 
 	carl9170_regwrite_finish();
-	err = carl9170_regwrite_result();
-	if (err)
-		return err;
-
-	return 0;
+	return carl9170_regwrite_result();
 }
 
 static const struct carl9170_phy_freq_params *
-- 
2.5.3

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html