netdev - [PATCH 08/15] net: wireless: simplify return flow for usb_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1445439337-19055-9-git-send-email-punitvara@gmail.com>
Date:	Wed, 21 Oct 2015 20:25:30 +0530
From:	Punit Vara <punitvara@...il.com>
To:	kvalo@....qualcomm.com
Cc:	stas.yakovlev@...il.com, chaoming_li@...lsil.com.cn,
	Larry.Finger@...inger.net, chunkeey@...glemail.com,
	sgruszka@...hat.com, brudley@...adcom.com, arend@...adcom.com,
	linville@...driver.com, jirislaby@...il.com, mickflemm@...il.com,
	mcgrof@...not-panic.com, k.eugene.e@...il.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	brcm80211-dev-list@...adcom.com, wcn36xx@...ts.infradead.org,
	johannes.berg@...el.com, meuleman@...adcom.com,
	Punit Vara <punitvara@...il.com>
Subject: [PATCH 08/15] net: wireless: simplify return flow for usb_control_msg

This patch is to the at76c50x-usb.c file that fixes up warning
reported by coccicheck:

WARNING: end returns can be simplified if negative or 0 value

Prefer direct return value instead of writing 2-3 more sentence.

Signed-off-by: Punit Vara <punitvara@...il.com>
---
 drivers/net/wireless/at76c50x-usb.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/wireless/at76c50x-usb.c b/drivers/net/wireless/at76c50x-usb.c
index dab2513..09427f6 100644
--- a/drivers/net/wireless/at76c50x-usb.c
+++ b/drivers/net/wireless/at76c50x-usb.c
@@ -544,13 +544,10 @@ static void at76_ledtrig_tx_activity(void)
 static int at76_remap(struct usb_device *udev)
 {
 	int ret;
-	ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a,
+	return usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a,
 			      USB_TYPE_VENDOR | USB_DIR_OUT |
 			      USB_RECIP_INTERFACE, 0, 0, NULL, 0,
 			      USB_CTRL_GET_TIMEOUT);
-	if (ret < 0)
-		return ret;
-	return 0;
 }
 
 static int at76_get_op_mode(struct usb_device *udev)
-- 
2.5.3

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html