netdev - Re: [PATCH net-next] ipvlan: read direct ifindex instead of iflink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151021132611.436eafe6@griffin>
Date:	Wed, 21 Oct 2015 13:26:10 +0200
From:	Jiri Benc <jbenc@...hat.com>
To:	Brenden Blanco <bblanco@...mgrid.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, maheshb@...gle.com
Subject: Re: [PATCH net-next] ipvlan: read direct ifindex instead of iflink

On Tue, 20 Oct 2015 16:47:33 -0700, Brenden Blanco wrote:
> --- a/drivers/net/ipvlan/ipvlan_core.c
> +++ b/drivers/net/ipvlan/ipvlan_core.c
> @@ -348,7 +348,7 @@ static int ipvlan_process_v4_outbound(struct sk_buff *skb)
>  	struct rtable *rt;
>  	int err, ret = NET_XMIT_DROP;
>  	struct flowi4 fl4 = {
> -		.flowi4_oif = dev_get_iflink(dev),
> +		.flowi4_oif = dev->ifindex,

The current code is obviously wrong and the patch makes sense.

Reviewed-by: Jiri Benc <jbenc@...hat.com>

-- 
Jiri Benc
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html