netdev - Re: [RFC v3 2/2] iwlwifi: mvm: send large SKBs to the transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1445515406.22974.107.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 22 Oct 2015 05:03:26 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Emmanuel Grumbach <emmanuel.grumbach@...el.com>
Cc:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	sara.sharon@...el.com, ido@...ery.com
Subject: Re: [RFC v3 2/2] iwlwifi: mvm: send large SKBs to the transport

On Wed, 2015-10-21 at 21:34 +0300, Emmanuel Grumbach wrote:
> +
> +		if (skb->protocol == htons(ETH_P_IP)) {
> +			ip_hdr(tmp)->id = ip_hdr(skb)->id;

Too late, you already called consume_skb(skb).
So this is a potential use after free.

> +			be16_add_cpu(&ip_hdr(tmp)->id, i * num_subframes);
> +		}
> +


I would use 

base_id = ip_hdr(skb)->id; // before the consume_skb(skb)

ip_hdr(tmp)->id = htons(base_id + i * num_subframes);


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html