netdev - Re: [PATCH net-next v3] netlink: Rightsize IFLA_AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151021.191532.1097000872602164221.davem@davemloft.net>
Date:	Wed, 21 Oct 2015 19:15:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ronen.arad@...el.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3] netlink: Rightsize IFLA_AF_SPEC size
 calculation

From: Ronen Arad <ronen.arad@...el.com>
Date: Mon, 19 Oct 2015 09:23:28 -0700

> if_nlmsg_size() overestimates the minimum allocation size of netlink
> dump request (when called from rtnl_calcit()) or the size of the
> message (when called from rtnl_getlink()). This is because
> ext_filter_mask is not supported by rtnl_link_get_af_size() and
> rtnl_link_get_size().
> 
> The over-estimation is significant when at least one netdev has many
> VLANs configured (8 bytes for each configured VLAN).
> 
> This patch-set "rightsizes" the protocol specific attribute size
> calculation by propagating ext_filter_mask to rtnl_link_get_af_size()
> and adding this a argument to get_link_af_size op in rtnl_af_ops.
> 
> Bridge module already used filtering aware sizing for notifications.
> br_get_link_af_size_filtered() is consistent with the modified
> get_link_af_size op so it replaces br_get_link_af_size() in br_af_ops.
> br_get_link_af_size() becomes unused and thus removed.
> 
> Signed-off-by: Ronen Arad <ronen.arad@...el.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html