netdev - Re: [PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56292C55.4030706@cogentembedded.com>
Date:	Thu, 22 Oct 2015 21:35:01 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Punit Vara <punitvara@...il.com>, jirislaby@...il.com
Cc:	mickflemm@...il.com, mcgrof@...not-panic.com, kvalo@...eaurora.org,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret
 returning 0

Hello.

On 10/22/2015 09:26 PM, Punit Vara wrote:

> This patch is to the ath5k/eeprom.c that fixes up warning caught by
> coccicheck:
>
> -Unneeded variable: "ret". Return "0" on line 1733
>
> Remove unneccesary variable ret created to return zero.
>
> Also removed empty line suggested by Sergei
>
> Signed-off-by: Punit Vara <punitvara@...il.com>
> ---
>   drivers/net/wireless/ath/ath5k/eeprom.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/eeprom.c b/drivers/net/wireless/ath/ath5k/eeprom.c
> index 94d34ee..0c82ea5 100644
> --- a/drivers/net/wireless/ath/ath5k/eeprom.c
> +++ b/drivers/net/wireless/ath/ath5k/eeprom.c
> @@ -1707,8 +1707,7 @@ ath5k_eeprom_read_spur_chans(struct ath5k_hw *ah)
>   	struct ath5k_eeprom_info *ee = &ah->ah_capabilities.cap_eeprom;
>   	u32 offset;
>   	u16 val;
> -	int ret = 0, i;
> -

    No, this one shouldn't have been removed. There should an empty line 
between the declarations and the statements.

> +	int i;
>   	offset = AR5K_EEPROM_CTL(ee->ee_version) +
>   				AR5K_EEPROM_N_CTLS(ee->ee_version);
>

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html