netdev - Re: [PATCH v5 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 23 Oct 2015 07:34:28 -0700
From:	Bjorn Andersson <bjorn@...o.se>
To:	Punit Vara <punitvara@...il.com>
Cc:	Kalle Valo <kvalo@...eaurora.org>,
	wcn36xx <wcn36xx@...ts.infradead.org>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	sergei.shtylyov@...entembedded.com, jirislaby@...il.com
Subject: Re: [PATCH v5 14/15] net: wireless: ath: Remove unneeded variable ret
 returning 0

On Thu, Oct 22, 2015 at 11:57 AM, Punit Vara <punitvara@...il.com> wrote:

Hi Punit,

> Remove empty line suggested by Sergei
>

A commit message is here to, in the future, help us all understand
what and why this change was made, so you should not include comments
about what you changed since a previous version of this patch.

> This patch is to the ath5k/eeprom.c that fixes up warning caught by
> coccicheck:
>

You don't need to indicate what files are changed in the commit
message, as that information is already available in the body of the
commit. And the comment stats the wrong file.

> Unneeded variable: "ret". Return "0" on line 980
>
> Remove unneeded variable ret created to return zero.
>

Both of these are only reiterating what the subject already states -
in two different ways. So you can easily remove them without loosing
any information. In fact, the subject is all you need to describe the
change.

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html