netdev - Re: ip_no_pmtu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 Oct 2015 10:01:50 -0700
From:	Vincent Li <vincent.mc.li@...il.com>
To:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: ip_no_pmtu_disc and UDP

 I think the no_pmtu_disc could be renamed to pmtu_disc to be less
confusion to users.

pmtu_disc: IP_PMTUDISC_DONT, clear DF bit
pmtu_disc: IP_PMTUDISC_WANT, set DF bit

 just my .2 cents

On Fri, Oct 23, 2015 at 9:45 AM, Vincent Li <vincent.mc.li@...il.com> wrote:
> Hi,
>
> It looks ip_no_pmtu_disc setting does not affect UDP IP packet DF bit
> setting, is that intended behavior? echo 0, 1, 2, 3 respectively to
> ip_no_pmtu_disc, UDP IP packet always have DF bit cleared, unless use
> IP_PMTUDISC_DO on IP_MTU_DISCOVER as ip man page says.
>
> in inet_create, seems to prove that.
>
>        if (net->ipv4.sysctl_ip_no_pmtu_disc)
>                 inet->pmtudisc = IP_PMTUDISC_DONT;
>         else
>                 inet->pmtudisc = IP_PMTUDISC_WANT;
>
> so I am wondering why UDP is excluded by ip_no_pmtu_disc, why in
> inet_create, not assign each individual ip_no_pmtu_disc setting to
> inet->pmtudisc but only check true and assign IP_PMTUDISC_DONT or
> IP_PMTUDISC_WANT only.
>
> Thanks
>
> Vincent
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html