lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 23 Oct 2015 15:19:32 +0800
From:	Joe Jin <joe.jin@...cle.com>
To:	boris.ostrovsky@...cle.com,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	"David S. Miller" <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, xen-devel@...ts.xenproject.org
Subject: Re: [Xen-devel] [PATCH 1/1] xen-netfront: limit max queues number to
 online cpus

We need to take care sysfs too, please ignore this patch, I'll create
new one later for review and comment.

Thanks,
Joe
On 10/23/2015 08:50 AM, Joe Jin wrote:
> Should not allocate queues number more than online cpus.
> 
> Signed-off-by: Joe Jin <joe.jin@...cle.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> Cc: David S. Miller <davem@...emloft.net>
> ---
>  drivers/net/xen-netfront.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index f821a97..1eebd4e 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -2137,7 +2137,7 @@ static int __init netif_init(void)
>  	/* Allow as many queues as there are CPUs if user has not
>  	 * specified a value.
>  	 */
> -	if (xennet_max_queues == 0)
> +	if (xennet_max_queues == 0 || xennet_max_queues > num_online_cpus())
>  		xennet_max_queues = num_online_cpus();
>  
>  	return xenbus_register_frontend(&netfront_driver);
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists