netdev - Re: [PATCH net] ppp: fix pppoe_dev deletion condition in pppoe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151023.033048.1984003889137051787.davem@davemloft.net>
Date:	Fri, 23 Oct 2015 03:30:48 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	g.nault@...halink.fr
Cc:	netdev@...r.kernel.org, paulus@...ba.org,
	nuclearcat@...learcat.com, Matt.Bennett@...iedtelesis.co.nz
Subject: Re: [PATCH net] ppp: fix pppoe_dev deletion condition in
 pppoe_release()

From: Guillaume Nault <g.nault@...halink.fr>
Date: Thu, 22 Oct 2015 16:57:10 +0200

> We can't rely on PPPOX_ZOMBIE to decide whether to clear po->pppoe_dev.
> PPPOX_ZOMBIE can be set by pppoe_disc_rcv() even when po->pppoe_dev is
> NULL. So we have no guarantee that (sk->sk_state & PPPOX_ZOMBIE) implies
> (po->pppoe_dev != NULL).
> Since we're releasing a PPPoE socket, we want to release the pppoe_dev
> if it exists and reset sk_state to PPPOX_DEAD, no matter the previous
> value of sk_state. So we can just check for po->pppoe_dev and avoid any
> assumption on sk->sk_state.
> 
> Fixes: 2b018d57ff18 ("pppoe: drop PPPOX_ZOMBIEs in pppoe_release")
> Signed-off-by: Guillaume Nault <g.nault@...halink.fr>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html