lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 23 Oct 2015 12:46:28 +0100
From:	Robert Shearman <>
To:	Roopa Prabhu <>, <>
CC:	<>, <>
Subject: Re: [PATCH net-next v5 1/2] mpls: multipath route support

On 23/10/15 01:16, Roopa Prabhu wrote:
> From: Roopa Prabhu <>
> This patch adds support for MPLS multipath routes.
> Includes following changes to support multipath:
> - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'
> - 'struct mpls_nh' represents a mpls nexthop label forwarding entry
> - moves mpls route and nexthop structures into internal.h
> - A mpls_route can point to multiple mpls_nh structs
> - the nexthops are maintained as a array (similar to ipv4 fib)
> - In the process of restructuring, this patch also consistently changes
>    all labels to u8
> - Adds support to parse/fill RTA_MULTIPATH netlink attribute for
> multipath routes similar to ipv4/v6 fib
> - In this patch, the multipath route nexthop selection algorithm
> simply returns the first nexthop. It is replaced by a
> hash based algorithm from Robert Shearman in the next patch
> - mpls_route_update cleanup: remove 'dev' handling in mpls_route_update.
> mpls_route_update though implemented to update based on dev, it was
> never used that way. And the dev handling gets tricky with multiple nexthops.
> Cannot match against any single nexthops dev. So, this patch removes the unused
> 'dev' handling in mpls_route_update.
> Example:
> $ip -f mpls route add 100 nexthop as 200 via inet dev swp1 \
>                  nexthop as 700 via inet dev swp2 \
>                  nexthop as 800 via inet dev swp3
> $ip  -f mpls route show
> 100
>          nexthop as to 200 via inet  dev swp1
>          nexthop as to 700 via inet  dev swp2
>          nexthop as to 800 via inet  dev swp3
> Signed-off-by: Roopa Prabhu <>

Acked-by: Robert Shearman <>

I think that find_outdev could be simplified, but as it's now clear what 
the expectations are with dev refcounts are during route update I'm 
happy with this latest patch.
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists