netdev - Re: [PATCH net-next 00/16] tipc: improve broadcast implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151024.070247.207024292559101493.davem@davemloft.net>
Date:	Sat, 24 Oct 2015 07:02:47 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jon.maloy@...csson.com
Cc:	netdev@...r.kernel.org, paul.gortmaker@...driver.com,
	parthasarathy.xx.bhuvaragan@...csson.com,
	richard.alpe@...csson.com, ying.xue@...driver.com,
	maloy@...jonn.com, tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net-next 00/16] tipc: improve broadcast implementation

From: Jon Maloy <jon.maloy@...csson.com>
Date: Thu, 22 Oct 2015 08:51:32 -0400

> The TIPC broadcast link implementation is currently complex and hard to
> follow. It also incurs some amount of code and structure duplication,
> something that can be reduced significantly with a little effort.
> 
> This commit series introduces a number of improvements which address
> both the locking structure, the code/structure duplication issue, and
> the overall readbility of the code.
> 
> The series consists of three main parts:
> 
> 1-7: Adaptation to the new link structure, and preparation for the next
>      step. In particular, we want the broadcast transmission link to
>      have a life cycle that is longer than any of its potential (unicast
>      and broadcast receive links) users. This eliminates the need to
>      always test for the presence of this link before accessing it.
> 
> 8-10: This is what is really new in this series. Commit #9 is by far
>       the largest and most important one, because it moves most of
>       the broadcast functionality into link.c, partially reusing the
>       fields and functionality of the unicast link. The removal of
>       the "node_map" infrastructure in commit #10 is also an important
>       achievement.
> 
> 11-16: Some improvements leveraging the changes made in the previous
>        commits.
> 
> The series needs commit 53387c4e22ac ("tipc: extend broadcast link window size")
> and commit e53567948f82 ("tipc: conditionally expand buffer headroom over udp tunnel")
> which are both present in 'net' but not yet in 'net-next', to apply cleanly.

Series applied, thanks Jon.

And I really appreciate the exact explanation of what this series
depended upon.

Thanks again.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html