netdev - Re: [PATCH net-next 6/8] xen-netback: pass an L4 or L3 skb hash value to the frontend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151026170545.GF18674@zion.uk.xensource.com>
Date:	Mon, 26 Oct 2015 17:05:45 +0000
From:	Wei Liu <wei.liu2@...rix.com>
To:	Paul Durrant <paul.durrant@...rix.com>
CC:	<netdev@...r.kernel.org>, <xen-devel@...ts.xenproject.org>,
	Ian Campbell <ian.campbell@...rix.com>,
	Wei Liu <wei.liu2@...rix.com>
Subject: Re: [PATCH net-next 6/8] xen-netback: pass an L4 or L3 skb hash
 value to the frontend

On Wed, Oct 21, 2015 at 11:36:23AM +0100, Paul Durrant wrote:
> If the frontend indicates it's capable (see netif.h for details) and an
> skb has an L4 or L3 hash value then pass the value to the frontend in
> a xen_netif_extra_info segment.
> 
> Signed-off-by: Paul Durrant <paul.durrant@...rix.com>
> Cc: Ian Campbell <ian.campbell@...rix.com>
> Cc: Wei Liu <wei.liu2@...rix.com>

Reviewed-by: Wei Liu <wei.liu2@...rix.com>

>  static int xenvif_rx_ring_slots_needed(struct xenvif *vif)
>  {
> -	if (vif->gso_mask)
> -		return DIV_ROUND_UP(vif->dev->gso_max_size, PAGE_SIZE) + 1;
> +	int needed;
> +
> +	if (vif->gso_mask || vif->gso_prefix_mask)

It seems like this line should become a patch for -stable?

>  		xenvif_add_frag_responses(queue, status,
> diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
> index 2fa8a16..a31bcee 100644
> --- a/drivers/net/xen-netback/xenbus.c
> +++ b/drivers/net/xen-netback/xenbus.c
> @@ -1037,6 +1037,11 @@ static int read_xenbus_vif_flags(struct backend_info *be)
>  		val = 0;
>  	vif->multicast_control = !!val;
>  
> +	if (xenbus_scanf(XBT_NIL, dev->otherend, "feature-hash",
> +			 "%d", &val) < 0)
> +		val = 0;

Again, feel free to retain my reviewed-by if this changes in next
version.

Wei.

> +	vif->hash_extra = !!val;
> +
>  	return 0;
>  }
>  
> -- 
> 2.1.4
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html