netdev - Re: [Intel-wired-lan] [PATCH net-next 0/4] Automatic adjustment of max frame size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <562D7D5A.6050400@lab.ntt.co.jp>
Date:	Mon, 26 Oct 2015 10:09:46 +0900
From:	Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
To:	"David S . Miller" <davem@...emloft.net>
Cc:	Jacob Keller <jacob.e.keller@...el.com>, netdev@...r.kernel.org,
	Vlad Yasevich <vyasevich@...il.com>,
	Stephen Hemminger <stephen@...workplumber.org>,
	intel-wired-lan@...ts.osuosl.org, Patrick McHardy <kaber@...sh.net>
Subject: Re: [Intel-wired-lan] [PATCH net-next 0/4] Automatic adjustment of
 max frame size

On 2015/10/23 13:46, ND Linux CI Server wrote:
...
> checkpatch.pl has some complaints:
> 
> --------------------------------------------------------------------------------
> 
> checkpatch.pl results for patch "[PATCH 2/4] e1000e: Add ndo_enc_hdr_len"
> 
> WARNING:LONG_LINE: line over 80 characters
> #53: FILE: drivers/net/ethernet/intel/e1000e/netdev.c:3981:
> +		if (adapter->max_frame_size > VLAN_ETH_FRAME_LEN + ETH_FCS_LEN) {
> 
> WARNING:LONG_LINE: line over 80 characters
> #62: FILE: drivers/net/ethernet/intel/e1000e/netdev.c:4000:
> +		if (adapter->max_frame_size > VLAN_ETH_FRAME_LEN + ETH_FCS_LEN) {
> 
> WARNING:LONG_LINE: line over 80 characters
> #71: FILE: drivers/net/ethernet/intel/e1000e/netdev.c:4014:
> +		if (adapter->max_frame_size <= VLAN_ETH_FRAME_LEN + ETH_FCS_LEN) {
> 
> total: 0 errors, 3 warnings, 0 checks, 184 lines checked

I was aware of these warnings but my understanding was that lines
without over 80 characters are not mandatory requirement and a short
overrun can be acceptable, like 81 or 82... Not sure what made me think
so, though.

Anyway, I will fix these warnings.

Thanks,
Toshiaki Makita

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html