netdev - Re: [PATCH 2/2] net: add driver for Netronome NFP4000/NFP6000 NIC VFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151026.182307.873190227567325622.davem@davemloft.net>
Date:	Mon, 26 Oct 2015 18:23:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jakub.kicinski@...ronome.com
Cc:	netdev@...r.kernel.org, rolf.neugebauer@...ronome.com,
	jason.mcmullan@...ronome.com, simon.horman@...ronome.com
Subject: Re: [PATCH 2/2] net: add driver for Netronome NFP4000/NFP6000 NIC
 VFs

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Fri, 23 Oct 2015 19:58:11 +0100

> +struct nfp_net_tx_buf {
> +	struct sk_buff *skb;
> +	dma_addr_t dma_addr;
> +	short int fidx;
> +	u16 pkt_cnt;
> +	u32 real_len;
> +};

This packs very poorly, and has a lot of padding holes.  Better ordering
would be:

struct nfp_net_tx_buf {
	struct sk_buff *skb;
	dma_addr_t dma_addr;
	u32 real_len;
	short int fidx;
	u16 pkt_cnt;
};

You really should audit the most core datastructures in this driver
for the same problem.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html