netdev - Re: [RFC PATCH 3/3] net: dsa: make usage of mv88e6xxx common remove function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201510280007.EATv1sKe%fengguang.wu@intel.com>
Date:	Wed, 28 Oct 2015 01:00:01 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Neil Armstrong <narmstrong@...libre.com>
Cc:	kbuild-all@...org, "David S. Miller" <davem@...emloft.net>,
	Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	Guenter Roeck <linux@...ck-us.net>,
	vivien.didelot@...oirfairelinux.com,
	Fabian Frederick <fabf@...net.be>,
	Pavel Nakonechny <pavel.nakonechny@...tlab.ru>,
	Joe Perches <joe@...ches.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 3/3] net: dsa: make usage of mv88e6xxx common remove
 function

Hi Neil,

[auto build test ERROR on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Neil-Armstrong/net-dsa-cleanup-dsa-driver/20151028-003842
config: x86_64-randconfig-x010-201543 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

>> drivers/net/dsa/mv88e6123_61_65.c:125:2: error: unknown field 'remove' specified in initializer
     .remove   = mv88e6xxx_remove_common,
     ^
>> drivers/net/dsa/mv88e6123_61_65.c:125:14: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
     .remove   = mv88e6xxx_remove_common,
                 ^
   drivers/net/dsa/mv88e6123_61_65.c:125:14: note: (near initialization for 'mv88e6123_61_65_switch_driver.set_addr')
--
>> drivers/net/dsa/mv88e6352.c:324:2: error: unknown field 'remove' specified in initializer
     .remove   = mv88e6xxx_remove_common,
     ^
>> drivers/net/dsa/mv88e6352.c:324:14: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
     .remove   = mv88e6xxx_remove_common,
                 ^
   drivers/net/dsa/mv88e6352.c:324:14: note: (near initialization for 'mv88e6352_switch_driver.set_addr')

vim +/remove +125 drivers/net/dsa/mv88e6123_61_65.c

   119	
   120	struct dsa_switch_driver mv88e6123_61_65_switch_driver = {
   121		.tag_protocol		= DSA_TAG_PROTO_EDSA,
   122		.priv_size		= sizeof(struct mv88e6xxx_priv_state),
   123		.probe			= mv88e6123_61_65_probe,
   124		.setup			= mv88e6123_61_65_setup,
 > 125		.remove			= mv88e6xxx_remove_common,
   126		.set_addr		= mv88e6xxx_set_addr_indirect,
   127		.phy_read		= mv88e6xxx_phy_read,
   128		.phy_write		= mv88e6xxx_phy_write,

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (28624 bytes)