netdev - Re: [RFC PATCH 1/3] net: dsa: bcm_sf2: cleanup resources in remove callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201510280116.ZmC8cieo%fengguang.wu@intel.com>
Date:	Wed, 28 Oct 2015 01:22:06 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Neil Armstrong <narmstrong@...libre.com>
Cc:	kbuild-all@...org, "David S. Miller" <davem@...emloft.net>,
	Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	Guenter Roeck <linux@...ck-us.net>,
	vivien.didelot@...oirfairelinux.com,
	Fabian Frederick <fabf@...net.be>,
	Pavel Nakonechny <pavel.nakonechny@...tlab.ru>,
	Joe Perches <joe@...ches.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 1/3] net: dsa: bcm_sf2: cleanup resources in remove
 callback

Hi Neil,

[auto build test ERROR on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Neil-Armstrong/net-dsa-cleanup-dsa-driver/20151028-003842
config: x86_64-allmodconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

>> drivers/net/dsa/bcm_sf2.c:1077:2: error: unknown field 'remove' specified in initializer
     .remove   = bcm_sf2_sw_remove,
     ^
>> drivers/net/dsa/bcm_sf2.c:1077:14: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
     .remove   = bcm_sf2_sw_remove,
                 ^
   drivers/net/dsa/bcm_sf2.c:1077:14: note: (near initialization for 'bcm_sf2_switch_driver.setup')

vim +/remove +1077 drivers/net/dsa/bcm_sf2.c

  1071	}
  1072	
  1073	static struct dsa_switch_driver bcm_sf2_switch_driver = {
  1074		.tag_protocol		= DSA_TAG_PROTO_BRCM,
  1075		.priv_size		= sizeof(struct bcm_sf2_priv),
  1076		.probe			= bcm_sf2_sw_probe,
> 1077		.remove			= bcm_sf2_sw_remove,
  1078		.setup			= bcm_sf2_sw_setup,
  1079		.set_addr		= bcm_sf2_sw_set_addr,
  1080		.get_phy_flags		= bcm_sf2_sw_get_phy_flags,

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (50058 bytes)