lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Oct 2015 15:22:55 -0700 From: Tom Herbert <tom@...bertland.com> To: Hannes Frederic Sowa <hannes@...essinduktion.org> Cc: Linux Kernel Network Developers <netdev@...r.kernel.org>, Eric Dumazet <edumazet@...gle.com>, Vladislav Yasevich <vyasevich@...il.com>, Benjamin Coddington <bcodding@...hat.com> Subject: Re: [PATCH net-next v3 1/4] ipv4: no CHECKSUM_PARTIAL on MSG_MORE corked sockets On Tue, Oct 27, 2015 at 2:40 PM, Hannes Frederic Sowa <hannes@...essinduktion.org> wrote: > We cannot reliable calculate packet size on MSG_MORE corked sockets > and thus cannot decide if they are going to be fragmented later on, > so better not use CHECKSUM_PARTIAL in the first place. > > Cc: Eric Dumazet <edumazet@...gle.com> > Cc: Vlad Yasevich <vyasevich@...il.com> > Cc: Benjamin Coddington <bcodding@...hat.com> > Cc: Tom Herbert <tom@...bertland.com> > Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org> > --- > net/ipv4/ip_output.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c > index 50e2973..0b02417 100644 > --- a/net/ipv4/ip_output.c > +++ b/net/ipv4/ip_output.c > @@ -911,6 +911,7 @@ static int __ip_append_data(struct sock *sk, > if (transhdrlen && > length + fragheaderlen <= mtu && > rt->dst.dev->features & NETIF_F_V4_CSUM && > + !(flags & MSG_MORE) && I still don't understand this. It seems like the effect is to disable checksum offload for all UDP messages sent with MSG_MORE flag set. > !exthdrlen) > csummode = CHECKSUM_PARTIAL; > > -- > 2.5.0 > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists