netdev - Re: [PATCH net-next] bridge: set is_local and is_static before fdb entry is added to the fdb hashtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201510271206.HPbBjdTp%fengguang.wu@intel.com>
Date:	Tue, 27 Oct 2015 12:16:51 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:	kbuild-all@...org, davem@...emloft.net, stephen@...workplumber.org,
	nikolay@...ulusnetworks.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bridge: set is_local and is_static before fdb
 entry is added to the fdb hashtable

Hi Roopa,

[auto build test ERROR on net-next/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Roopa-Prabhu/bridge-set-is_local-and-is_static-before-fdb-entry-is-added-to-the-fdb-hashtable/20151027-120635
config: i386-randconfig-x009-201543 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   net/bridge/br_fdb.c: In function 'br_fdb_external_learn_add':
>> net/bridge/br_fdb.c:1103:9: error: too few arguments to function 'fdb_create'
      fdb = fdb_create(head, p, addr, vid);
            ^
   net/bridge/br_fdb.c:495:37: note: declared here
    static struct net_bridge_fdb_entry *fdb_create(struct hlist_head *head,
                                        ^

vim +/fdb_create +1103 net/bridge/br_fdb.c

3aeb6617 Jiri Pirko    2015-01-15  1097  	ASSERT_RTNL();
cf6b8e1e Scott Feldman 2014-11-28  1098  	spin_lock_bh(&br->hash_lock);
cf6b8e1e Scott Feldman 2014-11-28  1099  
cf6b8e1e Scott Feldman 2014-11-28  1100  	head = &br->hash[br_mac_hash(addr, vid)];
cf6b8e1e Scott Feldman 2014-11-28  1101  	fdb = fdb_find(head, addr, vid);
cf6b8e1e Scott Feldman 2014-11-28  1102  	if (!fdb) {
cf6b8e1e Scott Feldman 2014-11-28 @1103  		fdb = fdb_create(head, p, addr, vid);
cf6b8e1e Scott Feldman 2014-11-28  1104  		if (!fdb) {
cf6b8e1e Scott Feldman 2014-11-28  1105  			err = -ENOMEM;
cf6b8e1e Scott Feldman 2014-11-28  1106  			goto err_unlock;

:::::: The code at line 1103 was first introduced by commit
:::::: cf6b8e1eedffd9ef9a22c0c9453d752b07daf89a bridge: add API to notify bridge driver of learned FBD on offloaded device

:::::: TO: Scott Feldman <sfeldma@...il.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (26664 bytes)