netdev - stmmac: Reporting ethtool_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <562F1577.8040803@electromag.com.au>
Date:	Tue, 27 Oct 2015 14:11:03 +0800
From:	Phil Reid <preid@...ctromag.com.au>
To:	netdev@...r.kernel.org
Cc:	peppe.cavallaro@...com
Subject: stmmac: Reporting ethtool_ts_info

G'day All,

The stmmac driver checks (priv->hwts_tx_en) && (priv->hwts_rx_en) before 
reporting WHTSTAMP capabilities.
No other driver seems to do this. hwts_*_en indicate if timestamping is 
enabled, not if the interface is capable of it.
Instead they check there capabilities. Which would be 
(priv->dma_cap.time_stamp || priv->dma_cap.atime_stamp)

Does this seem reasonable?

-- 
Regards
Phil Reid

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html