netdev - Re: [net PATCH] fib_trie: leaf_walk_rcu should not compute key if key is less than pn->key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151027.181538.2065720176501734630.davem@davemloft.net>
Date:	Tue, 27 Oct 2015 18:15:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	aduyck@...antis.com
Cc:	netdev@...r.kernel.org, brak@...eservers.com
Subject: Re: [net PATCH] fib_trie: leaf_walk_rcu should not compute key if
 key is less than pn->key

From: Alexander Duyck <aduyck@...antis.com>
Date: Tue, 27 Oct 2015 15:06:45 -0700

> We were computing the child index in cases where the key value we were
> looking for was actually less than the base key of the tnode.  As a result
> we were getting incorrect index values that would cause us to skip over
> some children.
> 
> To fix this I have added a test that will force us to use child index 0 if
> the key we are looking for is less than the key of the current tnode.
> 
> Fixes: 8be33e955cb9 ("fib_trie: Fib walk rcu should take a tnode and key instead of a trie and a leaf")
> Reported-by: Brian Rak <brak@...eservers.com>
> Signed-off-by: Alexander Duyck <aduyck@...antis.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html