netdev - Re: [PATCH v2 5/6] net: dsa: add missing calls in dsa_switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201510292127.akIl2ihS%fengguang.wu@intel.com>
Date:	Thu, 29 Oct 2015 21:44:58 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Neil Armstrong <narmstrong@...libre.com>
Cc:	kbuild-all@...org, "David S. Miller" <davem@...emloft.net>,
	Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	Guenter Roeck <linux@...ck-us.net>,
	vivien.didelot@...oirfairelinux.com,
	Fabian Frederick <fabf@...net.be>,
	Pavel Nakonechny <pavel.nakonechny@...tlab.ru>,
	Joe Perches <joe@...ches.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Frode Isaksen <fisaksen@...libre.com>
Subject: Re: [PATCH v2 5/6] net: dsa: add missing calls in dsa_switch_destroy

Hi Neil,

[auto build test ERROR on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Neil-Armstrong/Further-fix-for-dsa-unbinding/20151029-212633
config: x86_64-randconfig-x010-201543 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: the linux-review/Neil-Armstrong/Further-fix-for-dsa-unbinding/20151029-212633 HEAD 3c957c00de125eeffe9f50eda7cf94a98855f615 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   net/dsa/dsa.c: In function 'dsa_switch_destroy':
>> net/dsa/dsa.c:459:18: error: 'p' undeclared (first use in this function)
      phy_disconnect(p->phy);
                     ^
   net/dsa/dsa.c:459:18: note: each undeclared identifier is reported only once for each function it appears in

vim +/p +459 net/dsa/dsa.c

   453	
   454			if (!ds->ports[port])
   455				continue;
   456	
   457			netif_carrier_off(ds->ports[port]);
   458			unregister_netdev(ds->ports[port]);
 > 459			phy_disconnect(p->phy);
   460			free_netdev(ds->ports[port]);
   461		}
   462	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (28624 bytes)