netdev - Re: [PATCHv3 net 0/2] ipv4: fix problems from the RTNH_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151030165326.GA8027@gospo.home.greyhouse.net>
Date:	Fri, 30 Oct 2015 12:53:27 -0400
From:	Andy Gospodarek <gospo@...ulusnetworks.com>
To:	Julian Anastasov <ja@....bg>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCHv3 net 0/2] ipv4: fix problems from the RTNH_F_LINKDOWN
 introduction

On Fri, Oct 30, 2015 at 10:23:32AM +0200, Julian Anastasov wrote:
> Fix two problems from the change that introduced RTNH_F_LINKDOWN
> flag. The first patch deals with the removal of local route on
> DOWN event. The second patch makes sure the RTNH_F_LINKDOWN
> flag is properly updated on UP event because the DOWN event
> sets it in all cases.
> 
> v2->v3:
> - use bool for force var
> 
> v1->v2:
> - forgot to add ifconfig dummy0 down in the test case
> - split to 2 patches
> 
> Julian Anastasov (2):
>   ipv4: fix to not remove local route on link down
>   ipv4: update RTNH_F_LINKDOWN flag on UP event

I had a chance to test both of these this morning and they look good.
Sorry for the delay.  Thanks for making force a bool to cover the single
case -- good suggestion by DaveM.

Reviewed-by: Andy Gospodarek <gospo@...ulusnetworks.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html