netdev - Re: [PATCH net] i40e: Look up MAC address in Open Firmware or IDPROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfqPpOdf38kjeKzUwgreuzHDkc9Lg0vPnUugw8vZwVzCQ@mail.gmail.com>
Date:	Fri, 30 Oct 2015 15:34:09 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Sowmini Varadhan <sowmini.varadhan@...cle.com>
Cc:	intel-wired-lan@...ts.osuosl.org, netdev <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	jeffrey.t.kirsher@...el.com, jesse.brandeburg@...el.com,
	shannon.nelson@...el.com, carolyn.wyborny@...el.com,
	donald.c.skidmore@...el.com, matthew.vick@...el.com,
	john.ronciak@...el.com, mitch.a.williams@...el.com,
	martin.petersen@...cle.com
Subject: Re: [PATCH net] i40e: Look up MAC address in Open Firmware or IDPROM

On Fri, Oct 30, 2015 at 1:26 PM, Sowmini Varadhan
<sowmini.varadhan@...cle.com> wrote:
> On (10/30/15 02:14), Andy Shevchenko wrote:
>>
>> Does the following has no stubs?
>>
>> > +       struct i40e_pf *pf = hw->back;
>> > +       struct device_node *dp = pci_device_to_OF_node(pf->pdev);
>> > +       const unsigned char *addr;
>> > +
>> > +       addr = of_get_mac_address(dp);
>>
>> ^^^
>
> I was not able to find any.
> I'm fixing up the rest and respinning V2 as a separate thread.

of_net.h contains the stub of of_get_mac_addr() which means you don't
need to put ugly ifdefs in the function.

Have no idea about CONFIG_SPARC though.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html