netdev - Re: [PATCH] can: Use correct type in sizeof() in nla

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 Oct 2015 15:01:28 +0100
From:	Marek Vasut <marex@...x.de>
To:	"Marc Kleine-Budde" <mkl@...gutronix.de>
Cc:	linux-can@...r.kernel.org, Wolfgang Grandegger <wg@...ndegger.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] can: Use correct type in sizeof() in nla_put()

On Friday, October 30, 2015 at 02:40:26 PM, Marc Kleine-Budde wrote:
> On 10/30/2015 01:48 PM, Marek Vasut wrote:
> > The sizeof() is invoked on an incorrect variable, likely due to some
> > copy-paste error, and this might result in memory corruption. Fix this.
> > 
> > Signed-off-by: Marek Vasut <marex@...x.de>
> > Cc: Wolfgang Grandegger <wg@...ndegger.com>
> > Cc: Marc Kleine-Budde <mkl@...gutronix.de>
> > Cc: netdev@...r.kernel.org
> 
> Applies to can and added stable on Cc.

Are you absolutelly positive this doesn't break kernel ABI please ?

I am a little worried there, since the size of can_clock and can_ctrlmode
structures differ.

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html