lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 01 Nov 2015 11:47:30 -0500 (EST) From: David Miller <davem@...emloft.net> To: wen.gang.wang@...cle.com Cc: netdev@...r.kernel.org Subject: Re: [PATCH] ip: find correct route for socket which is not bound (v2) From: Wengang Wang <wen.gang.wang@...cle.com> Date: Fri, 25 Sep 2015 09:52:40 +0800 > diff --git a/net/ipv4/route.c b/net/ipv4/route.c > index 5f4a556..c0534c2 100644 > --- a/net/ipv4/route.c > +++ b/net/ipv4/route.c > @@ -2097,7 +2097,10 @@ struct rtable *__ip_route_output_key(struct net *net, struct flowi4 *fl4) > */ > > fl4->flowi4_oif = dev_out->ifindex; > - goto make_route; > + if (dev_out->flags & IFF_LOOPBACK) > + goto make_route; > + else > + goto lookup; > } This is still broken. By definition invoking fib_lookup() and depending upon it finding something in this path is going to break things for somebody, somewhere. Before your change, if we lacked a multicast route, the user would still get a functioning path. Furthermore, most of the other "goto make_route" cases in this function suffer from the same exact problem you're trying to solve. Therefore, special casing one instance makes no sense at all. I want you to, instead of making potentially lethal semantic changes here, fix the real problem instead. That is, I want you to fix how we do not cache routes we create merely because we lack a fib_info. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists