netdev - Re: [PATCH] NET: ATM: MPOA: Remove 32-bit timekeeping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151101.163909.2057353716684505796.davem@davemloft.net>
Date:	Sun, 01 Nov 2015 16:39:09 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ruchandani.tina@...il.com
Cc:	netdev@...r.kernel.org, arnd@...db.de, isdn@...ux-pingi.de,
	linux-kernel@...r.kernel.org, y2038@...ts.linaro.org
Subject: Re: [PATCH] NET: ATM: MPOA: Remove 32-bit timekeeping

From: Tina Ruchandani <ruchandani.tina@...il.com>
Date: Thu, 29 Oct 2015 22:01:07 -0700

> @@ -14,9 +15,9 @@ void atm_mpoa_init_cache(struct mpoa_client *mpc);
>  typedef struct in_cache_entry {
>  	struct in_cache_entry *next;
>  	struct in_cache_entry *prev;
> -	struct timeval  tv;
> -	struct timeval  reply_wait;
> -	struct timeval  hold_down;
> +	time64_t  tv;
> +	time64_t  reply_wait;
> +	time64_t  hold_down;
>  	uint32_t  packets_fwded;
>  	uint16_t  entry_state;
>  	uint32_t retry_time;
> @@ -51,7 +52,7 @@ struct in_cache_ops{
>  typedef struct eg_cache_entry{
>  	struct               eg_cache_entry *next;
>  	struct               eg_cache_entry *prev;
> -	struct               timeval  tv;
> +	time64_t	     tv;

Again, these structure member names like "tv" only make sense if
they store a "timeval".  Please rename these structure members
appropriately, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html