netdev - Re: [PATCH net] ipv6: fix crash on ICMPv6 redirects with prohibited/blackholed source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201511020718.Io3B1NFz%fengguang.wu@intel.com>
Date:	Mon, 2 Nov 2015 07:42:39 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Matthias Schiffer <mschiffer@...verse-factory.net>
Cc:	kbuild-all@...org, davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net] ipv6: fix crash on ICMPv6 redirects with
 prohibited/blackholed source

Hi Matthias,

[auto build test WARNING on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Matthias-Schiffer/ipv6-fix-crash-on-ICMPv6-redirects-with-prohibited-blackholed-source/20151102-072158
config: x86_64-allyesconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   net/ipv6/route.c: In function 'rt6_do_redirect':
>> net/ipv6/route.c:2102:14: warning: unused variable 'net' [-Wunused-variable]
     struct net *net = dev_net(skb->dev);
                 ^

vim +/net +2102 net/ipv6/route.c

^1da177e Linus Torvalds               2005-04-16  2086  				continue;
86872cb5 Thomas Graf                  2006-08-22  2087  			if (cfg->fc_metric && cfg->fc_metric != rt->rt6i_metric)
^1da177e Linus Torvalds               2005-04-16  2088  				continue;
d8d1f30b Changli Gao                  2010-06-10  2089  			dst_hold(&rt->dst);
c71099ac Thomas Graf                  2006-08-04  2090  			read_unlock_bh(&table->tb6_lock);
^1da177e Linus Torvalds               2005-04-16  2091  
86872cb5 Thomas Graf                  2006-08-22  2092  			return __ip6_del_rt(rt, &cfg->fc_nlinfo);
^1da177e Linus Torvalds               2005-04-16  2093  		}
^1da177e Linus Torvalds               2005-04-16  2094  	}
c71099ac Thomas Graf                  2006-08-04  2095  	read_unlock_bh(&table->tb6_lock);
^1da177e Linus Torvalds               2005-04-16  2096  
^1da177e Linus Torvalds               2005-04-16  2097  	return err;
^1da177e Linus Torvalds               2005-04-16  2098  }
^1da177e Linus Torvalds               2005-04-16  2099  
6700c270 David S. Miller              2012-07-17  2100  static void rt6_do_redirect(struct dst_entry *dst, struct sock *sk, struct sk_buff *skb)
a6279458 YOSHIFUJI Hideaki            2006-08-23  2101  {
e8599ff4 David S. Miller              2012-07-11 @2102  	struct net *net = dev_net(skb->dev);
a6279458 YOSHIFUJI Hideaki            2006-08-23  2103  	struct netevent_redirect netevent;
e8599ff4 David S. Miller              2012-07-11  2104  	struct rt6_info *rt, *nrt = NULL;
e8599ff4 David S. Miller              2012-07-11  2105  	struct ndisc_options ndopts;
e8599ff4 David S. Miller              2012-07-11  2106  	struct inet6_dev *in6_dev;
e8599ff4 David S. Miller              2012-07-11  2107  	struct neighbour *neigh;
71bcdba0 YOSHIFUJI Hideaki / 吉藤英明 2013-01-05  2108  	struct rd_msg *msg;
6e157b6a David S. Miller              2012-07-12  2109  	int optlen, on_link;
6e157b6a David S. Miller              2012-07-12  2110  	u8 *lladdr;

:::::: The code at line 2102 was first introduced by commit
:::::: e8599ff4b1d6b0d61e1074ae4ba9fca8dd0c41d0 ipv6: Move bulk of redirect handling into rt6_redirect().

:::::: TO: David S. Miller <davem@...emloft.net>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (50365 bytes)