netdev - Re: [PATCH net 1/2] isdn_ppp: Add checks for allocation failure in isdn_ppp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1446395008.25466.0.camel@decadent.org.uk>
Date:	Sun, 01 Nov 2015 16:23:28 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	isdn@...ux-pingi.de, linux-ppp@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH net 1/2] isdn_ppp: Add checks for allocation failure in
 isdn_ppp_open()

On Fri, 2015-10-16 at 00:46 -0700, David Miller wrote:
> From: Ben Hutchings <ben@...adent.org.uk>
> Date: Wed, 14 Oct 2015 18:51:14 +0100
> 
> > Compile-tested only.
> > 
> > Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> > ---
> >  drivers/isdn/i4l/isdn_ppp.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/drivers/isdn/i4l/isdn_ppp.c
> b/drivers/isdn/i4l/isdn_ppp.c
> > index c4198fa..86f9abe 100644
> > --- a/drivers/isdn/i4l/isdn_ppp.c
> > +++ b/drivers/isdn/i4l/isdn_ppp.c
> > @@ -301,6 +301,8 @@ isdn_ppp_open(int min, struct file *file)
> >       is->compflags = 0;
> >  
> >       is->reset = isdn_ppp_ccp_reset_alloc(is);
> > +     if (!is->reset)
> > +             return -ENOMEM;
> 
> Ben, your email client has corrupted both of these patches.
> 
> Please fix this up and resubmit, thanks.

Sorry about that; it is a regression in Evolution 3.18.

Ben.

-- 
Ben Hutchings
Nothing is ever a complete failure; it can always serve as a bad example.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)