lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 02 Nov 2015 13:03:23 -0800 From: Joe Perches <joe@...ches.com> To: madalin.bucur@...escale.com Cc: netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org, davem@...emloft.net, scottwood@...escale.com, igal.liberman@...escale.com, roy.pledge@...escale.com, ppc@...dchasers.com, pebolle@...cali.nl, joakim.tjernlund@...nsmode.se, gregkh@...uxfoundation.org Subject: Re: [net-next v4 3/8] dpaa_eth: add support for S/G frames On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote: > Add support for Scater/Gather (S/G) frames. The FMan can place > the frame content into multiple buffers and provide a S/G Table > (SGT) into one first buffer with references to the others. trivia: > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.h b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.h [] > @@ -347,7 +347,7 @@ static inline void clear_fd(struct qm_fd *fd) > } > > static inline int _dpa_tx_fq_to_id(const struct dpa_priv_s *priv, > - struct qman_fq *tx_fq) > + struct qman_fq *tx_fq) superfluous change? > +void dpa_release_sgt(struct qm_sg_entry *sgt) > +{ > + struct dpa_bp *dpa_bp; > + struct bm_buffer bmb[DPA_BUFF_RELEASE_MAX]; > + u8 i = 0, j; Using int may be better than u8 for indexing -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists