netdev - Re: [PATCH v2 net 2/2] ppp, slip: Validate VJ compression slot parameters completely

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151102.162522.1417839400954115202.davem@davemloft.net>
Date:	Mon, 02 Nov 2015 16:25:22 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ben@...adent.org.uk
Cc:	isdn@...ux-pingi.de, linux-ppp@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2 net 2/2] ppp, slip: Validate VJ compression slot
 parameters completely

From: Ben Hutchings <ben@...adent.org.uk>
Date: Sun, 1 Nov 2015 16:22:53 +0000

> Currently slhc_init() treats out-of-range values of rslots and tslots
> as equivalent to 0, except that if tslots is too large it will
> dereference a null pointer (CVE-2015-7799).
> 
> Add a range-check at the top of the function and make it return an
> ERR_PTR() on error instead of NULL.  Change the callers accordingly.
> 
> Compile-tested only.
> 
> Reported-by: 郭永刚 <guoyonggang@....cn>
> References: http://article.gmane.org/gmane.comp.security.oss.general/17908
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>

Applied.