netdev - Re: [RFC PATCH net-next 2/6] net: dsa: mv88e6060: use the correct InitReady bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56375EFA.7050509@cogentembedded.com>
Date:	Mon, 2 Nov 2015 16:02:50 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Neil Armstrong <narmstrong@...libre.com>, netdev@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Florian Fainelli <f.fainelli@...il.com>,
	Andrew Lunn <andrew@...n.ch>,
	Guenter Roeck <linux@...ck-us.net>,
	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Subject: Re: [RFC PATCH net-next 2/6] net: dsa: mv88e6060: use the correct
 InitReady bit

Hello.

On 11/2/2015 1:57 PM, Neil Armstrong wrote:

> According to the mv88e6060 datasheet, the InitReady bit position
> is 11 and the polarity is inverted.
> Use the bit correctly to detect the end of initialization.
>
> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
> ---
>   drivers/net/dsa/mv88e6060.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/mv88e6060.c b/drivers/net/dsa/mv88e6060.c
> index 6885ef5..c10880f 100644
> --- a/drivers/net/dsa/mv88e6060.c
> +++ b/drivers/net/dsa/mv88e6060.c
> @@ -102,7 +102,7 @@ static int mv88e6060_switch_reset(struct dsa_switch *ds)
>   	timeout = jiffies + 1 * HZ;
>   	while (time_before(jiffies, timeout)) {
>   		ret = REG_READ(REG_GLOBAL, 0x00);
> -		if ((ret & 0x8000) == 0x0000)
> +		if ((ret & 0x800) != 0x0000)

    You could as well drop != 0.

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html