netdev - Re: [PATCH net-next] af_unix: optimize unix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151102.120822.1151065456395557870.davem@davemloft.net>
Date:	Mon, 02 Nov 2015 12:08:22 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	aconole@...heb.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] af_unix: optimize unix_writable by inlining

From: Aaron Conole <aconole@...heb.org>
Date: Mon,  2 Nov 2015 12:01:59 -0500

> unix_writable() originally was inlined, but was changed as part of
> commit 1586a5877db9 ("af_unix: do not report POLLOUT on
> listeners"). Re-enable the inline flag.
> 
> Signed-off-by: Aaron Conole <aconole@...heb.org>

This is never appropriate.

The compiler should be fixed to inline functions properly when
appropriate for the optimization level requested.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html