netdev - Re: [PATCH] arcnet/com20020: add LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151103.113432.1400073533179795014.davem@davemloft.net>
Date:	Tue, 03 Nov 2015 11:34:32 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	arnd@...db.de
Cc:	m.grzeschik@...gutronix.de, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arcnet/com20020: add LEDS_CLASS dependency

From: Arnd Bergmann <arnd@...db.de>
Date: Tue, 03 Nov 2015 14:51:29 +0100

> The newly added led trigger support in the com20020-pci driver causes
> build errors when CONFIG_LEDS_CLASS is disabled:
> 
> drivers/built-in.o: In function `com20020pci_probe':
> (.text+0x185dc4): undefined reference to `devm_led_classdev_register'
> (.text+0x185dd8): undefined reference to `devm_led_classdev_register'
> 
> This adds a Kconfig dependency to prevent the invalid configurations.
> Other drivers appear to be split 50:50 between 'select' and 'depends on'
> for this symbol, I picked 'depends on' as I could not find a common
> policy and it generally causes fewer problems.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 8890624a4e8c ("arcnet: com20020-pci: add led trigger support")

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html