netdev - Re: [PATCH net-next] net/core: fix for_each_netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151103.113456.1360164920793289224.davem@davemloft.net>
Date:	Tue, 03 Nov 2015 11:34:56 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jarod@...hat.com
Cc:	linux-kernel@...r.kernel.org, edumazet@...gle.com,
	j.vosburgh@...il.com, vfalico@...il.com, gospo@...ulusnetworks.com,
	jiri@...nulli.us, razor@...ckwall.org, mkubecek@...e.cz,
	alexander.duyck@...il.com, geert@...ux-m68k.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net/core: fix for_each_netdev_feature

From: Jarod Wilson <jarod@...hat.com>
Date: Tue,  3 Nov 2015 10:15:59 -0500

> As pointed out by Nikolay and further explained by Geert, the initial
> for_each_netdev_feature macro was broken, as feature would get set outside
> of the block of code it was intended to run in, thus only ever working for
> the first feature bit in the mask. While less pretty this way, this is
> tested and confirmed functional with multiple feature bits set in
> NETIF_F_UPPER_DISABLES.
 ...
> Fixes: fd867d51f ("net/core: generic support for disabling netdev features down stack")
 ...
> Signed-off-by: Jarod Wilson <jarod@...hat.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html