netdev - Re: [PATCH] ssb: mark ssb_bus_register as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151103175142.70320eef@wiggum>
Date:	Tue, 3 Nov 2015 17:51:42 +0100
From:	Michael Büsch <m@...s.ch>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	netdev@...r.kernel.org, Kalle Valo <kvalo@...eaurora.org>,
	linux-kernel@...r.kernel.org, zajec5@...il.com,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
Subject: Re: [PATCH] ssb: mark ssb_bus_register as __maybe_unused

On Tue, 03 Nov 2015 17:42:26 +0100
Arnd Bergmann <arnd@...db.de> wrote:

> On Tuesday 03 November 2015 17:27:21 Michael Büsch wrote:
> > On Tue, 03 Nov 2015 16:05:51 +0100
> > Arnd Bergmann <arnd@...db.de> wrote:
> >   
> > > The SoC variant of the ssb code is now optional like the other
> > > ones, which means we can build the framwork without any
> > > front-end, but that results in a warning:
> > > 
> > > drivers/ssb/main.c:616:12: warning: 'ssb_bus_register' defined but not used [-Wunused-function]
> > > 
> > > This annotates the ssb_bus_register function as __maybe_unused to
> > > shut up the warning. A configuration like this will not work on
> > > any hardware of course, but we still want this to silently build
> > > without warnings if the configuration is allowed in the first
> > > place.  
> > 
> > 
> > Is there a simple way to disallow this configuration?  
> 
> I could not come up with a simple one. We could turn 'CONFIG_SSB' into
> a silent option and have it selected by each bus specific driver,
> but then we also have to change all the device drivers (usb and
> wireless I guess) to use 'depends on' rather than 'select'.

The other way around?
The drivers already select SSB. However I think we should have SSB
selectable by user for the embedded case.

But well, I can live with this patch then. Kalle, you might apply it
with

Acked-by: Michael Buesch <m@...s.ch>

-- 
Michael

Content of type "application/pgp-signature" skipped