netdev - Re: [Patch net] ipv4: fix a potential deadlock in mcast getsockopt() path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 4 Nov 2015 06:49:13 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	kbuild-all@...org, netdev@...r.kernel.org, sasha.levin@...cle.com,
	Cong Wang <xiyou.wangcong@...il.com>,
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Subject: Re: [Patch net] ipv4: fix a potential deadlock in mcast getsockopt()
 path

Hi Cong,

[auto build test WARNING on net/master]
[also WARNING on: v4.3 next-20151103]

url:    https://github.com/0day-ci/linux/commits/Cong-Wang/ipv4-fix-a-potential-deadlock-in-mcast-getsockopt-path/20151104-055733
base:   https://github.com/0day-ci/linux Cong-Wang/ipv4-fix-a-potential-deadlock-in-mcast-getsockopt-path/20151104-055733
config: avr32-atngw100_defconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=avr32 

All warnings (new ones prefixed by >>):

   net/ipv4/ip_sockglue.c: In function 'ip_getsockopt':
>> net/ipv4/ip_sockglue.c:1504: warning: 'err' is used uninitialized in this function
   net/ipv4/ip_sockglue.c:1269: note: 'err' was declared here

vim +/err +1504 net/ipv4/ip_sockglue.c

  1488				return -EFAULT;
  1489			if (copy_to_user(optval, &ucval, 1))
  1490				return -EFAULT;
  1491		} else {
  1492			len = min_t(unsigned int, sizeof(int), len);
  1493			if (put_user(len, optlen))
  1494				return -EFAULT;
  1495			if (copy_to_user(optval, &val, len))
  1496				return -EFAULT;
  1497		}
  1498		return 0;
  1499	
  1500	out:
  1501		release_sock(sk);
  1502		if (needs_rtnl)
  1503			rtnl_unlock();
> 1504		return err;
  1505	}
  1506	
  1507	int ip_getsockopt(struct sock *sk, int level,
  1508			  int optname, char __user *optval, int __user *optlen)
  1509	{
  1510		int err;
  1511	
  1512		err = do_ip_getsockopt(sk, level, optname, optval, optlen, 0);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (11789 bytes)