netdev - Re: [PATCH] net: sched: kill dead code in sch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151103231513.GA26876@orbit.nwl.cc>
Date:	Wed, 4 Nov 2015 00:15:13 +0100
From:	Phil Sutter <phil@....cc>
To:	David Miller <davem@...emloft.net>
Cc:	shemming@...cade.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: sched: kill dead code in sch_choke.c

On Tue, Nov 03, 2015 at 01:32:44PM -0500, David Miller wrote:
> From: Phil Sutter <phil@....cc>
> Date: Tue,  3 Nov 2015 19:01:41 +0100
> 
> > It looks like this has never been used at all.
> > 
> > Signed-off-by: Phil Sutter <phil@....cc>
> 
> Indeed, from day one this was completely unreferenced.

I found it by accident when trying to find out whether choke was
class-full or not. :)

> One downside from marking so much stuff const is that an
> unreferenced static variable won't be warned as unused if
> it's const.

Interestingly, this topic was picked up again only just two months
ago[1]. Not sure though if that could be used for kernel code with all
it's specialties.

Cheers, Phil

[1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=28901
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html