netdev - Re: [PATCH net-next] mpls: support for dead routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151102.233718.457762701709770369.davem@davemloft.net>
Date:	Mon, 02 Nov 2015 23:37:18 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	roopa@...ulusnetworks.com
Cc:	ebiederm@...ssion.com, rshearma@...cade.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] mpls: support for dead routes

From: Roopa Prabhu <roopa@...ulusnetworks.com>
Date: Mon,  2 Nov 2015 13:08:49 -0800

> +		if ((nh->nh_flags & RTNH_F_DEAD) ||
> +		    (nh->nh_flags & RTNH_F_LINKDOWN))
> +			continue;

A single "& (RTNH_F_DEAD | RTNH_F_LINKDOWN)" is more efficient and
more canonical.

> +	if ((nh->nh_flags & RTNH_F_LINKDOWN) ||
> +	    (nh->nh_flags & RTNH_F_DEAD))
> +		rt->rt_nhn_alive--;

Likewise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html