netdev - Re: net: lockdep warning in ip_mc_msfget (net/ipv4/igmp.c:2400)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <563898A5.9050200@gmail.com>
Date:	Tue, 3 Nov 2015 09:21:09 -0200
From:	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:	Cong Wang <cwang@...pensource.com>,
	Sasha Levin <sasha.levin@...cle.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	LKML <linux-kernel@...r.kernel.org>, syzkaller@...glegroups.com,
	Dmitry Vyukov <dvyukov@...gle.com>
Subject: Re: net: lockdep warning in ip_mc_msfget (net/ipv4/igmp.c:2400)

Em 02-11-2015 22:38, Cong Wang escreveu:
> On Mon, Nov 2, 2015 at 1:31 PM, Cong Wang <cwang@...pensource.com> wrote:
>>
>> Good catch!
>>
>> This is probably introduced by:
>>
>> commit baf606d9c9b12517e47e0d1370e8aa9f7323f210
>> Author: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
>> Date:   Wed Mar 18 14:50:42 2015 -0300
>>
>>      ipv4,ipv6: grab rtnl before locking the socket

Yes, that commit introduced this inverse order situation by not fixing 
the get path of it.

>> I am thinking what is the right way to fix it...
>
> Please try the attached patch.
>
> Thanks!

Patch LGTM, same design and covered all rtnl_lock()s I could find on get 
path now. Thanks!

   Marcelo

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html