netdev - Re: [RFC][PATCH] net: arinc429: Add ARINC-429 stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56389C38.4080508@pengutronix.de>
Date:	Tue, 3 Nov 2015 12:36:24 +0100
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Aleksander Morgado <aleksander@...ksander.es>,
	Marek Vasut <marex@...x.de>
Cc:	Vostrikov Andrey <andrey.vostrikov@...entembedded.com>,
	Oliver Hartkopp <socketcan@...tkopp.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Wolfgang Grandegger <wg@...ndegger.com>,
	Andrew Lunn <andrew@...n.ch>
Subject: Re: [RFC][PATCH] net: arinc429: Add ARINC-429 stack

On 11/03/2015 11:36 AM, Aleksander Morgado wrote:
> On Mon, Nov 2, 2015 at 9:25 PM, Marek Vasut <marex@...x.de> wrote:
>>>> I was thinking about this and I mostly agree with you. Obviously, copying
>>>> the code this way was dumb. On the other hand, ARINC and CAN are two
>>>> different sort of busses, so I'd propose something slightly different
>>>> here to avoid confusion and prevent the future extensions (or protocols)
>>>> from adding unrelated cruft into the CAN stack.

> I'd keep them separate not because ARINC may add unrelated cruft into
> the CAN stack, but because ARINC is much simpler than CAN already...

What about maintainability? Why take care of two almost identical
subsystems? With making one stack "simpler" you increase, from my point
of view, the costs of maintaining even more. If you fix problems in one
stack you have to adopt the other, too.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)