netdev - Re: [PATCH net-next] ipv6: gro: support sit protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1446556053.23275.55.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 03 Nov 2015 05:07:33 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Wolfgang Walter <linux@...m.de>
Cc:	David Miller <davem@...emloft.net>, Jerry Chu <hkchu@...gle.com>,
	JesseGross <jesse@...ira.com>, Tom Herbert <tom@...bertland.com>,
	netdev <netdev@...r.kernel.org>, kernel-team@...com,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH net-next] ipv6: gro: support sit protocol

On Tue, 2015-11-03 at 13:57 +0100, Wolfgang Walter wrote:
> Am Montag, 19. Oktober 2015, 20:40:17 schrieb Eric Dumazet:
> > From: Eric Dumazet <edumazet@...gle.com>
> > 
> > Tom Herbert added SIT support to GRO with commit
> > 19424e052fb4 ("sit: Add gro callbacks to sit_offload"),
> > later reverted by Herbert Xu.
> > 
> > The problem came because Tom patch was building GRO
> > packets without proper meta data : If packets were locally
> > delivered, we would not care.
> > 
> > But if packets needed to be forwarded, GSO engine was not
> > able to segment individual segments.
> > 
> > With the following patch, we correctly set skb->encapsulation
> > and inner network header. We also update gso_type.
> > 
> 
> I'm running 4.1.11 / 4.1.12 with this patch on top now since over a week. 
> ISATAP works fine.

Perfect ! thanks a lot for testing !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html