lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 3 Nov 2015 16:33:59 -0800 From: Stephen Hemminger <shemming@...cade.com> To: Phil Sutter <phil@....cc> CC: <netdev@...r.kernel.org> Subject: Re: [iproute PATCH] iproute: fix filter_nlmsg On Thu, 29 Oct 2015 12:15:47 +0100 Phil Sutter <phil@....cc> wrote: > This patch is based upon an old Fedora bug[1] regarding the routing > setup of PPP links. I'm not quite sure if it still applies today or how > to trigger it, but looking at the change introducing this, it's > obviously a bug. > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=622782 > > Fixes: 4479282 ("iproute2: filter routing entries based on clone flag") > Signed-off-by: Phil Sutter <phil@....cc> > --- > ip/iproute.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ip/iproute.c b/ip/iproute.c > index eab512d..ea7e9aa 100644 > --- a/ip/iproute.c > +++ b/ip/iproute.c > @@ -151,7 +151,7 @@ static int filter_nlmsg(struct nlmsghdr *n, struct rtattr **tb, int host_len) > if (r->rtm_family == AF_INET6 && table != RT_TABLE_MAIN) > ip6_multiple_tables = 1; > > - if (filter.cloned == !(r->rtm_flags&RTM_F_CLONED)) > + if (filter.cloned && !(r->rtm_flags&RTM_F_CLONED)) > return 0; > > if (r->rtm_family == AF_INET6 && !ip6_multiple_tables) { Holding off on this, until there is an obvious reproduction. The patch looks right but this code has been around a long time and don't want any surprised users. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists