netdev - RE: [patch -next] qlogic/qed: remove bogus NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B5657A6538887040AD3A81F1008BEC63E68723@avmb3.qlogic.org>
Date:	Wed, 4 Nov 2015 13:31:51 +0000
From:	Yuval Mintz <Yuval.Mintz@...gic.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	Ariel Elior <Ariel.Elior@...gic.com>,
	Dept-Eng Everest Linux L2 <everest-linux-l2@...gic.com>,
	netdev <netdev@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [patch -next] qlogic/qed: remove bogus NULL check

> We check if "p_hwfn" is NULL and then dereference it in the error handling
> code.  I read the code and it isn't NULL so let's remove the check.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Our current interrupt handling logic is being uber-defensive. Thanks.

Acked-by: Yuval Mintz <Yuval.Mintz@...gic.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html